Add tests for adding multiple LWCAs #4679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New tests have been added to validate adding multiple LWCAs in plain PKI environment and in IPA environment. The CASigningUnit has been updated to no longer log an exception if the cert or key is missing since in LWCA case the exception is used as a mechanism to trigger the key retriever so it is actually not a problem. Instead, the exception will only be logged by other code where the exception indicates a real problem.
|
fmarco76
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New tests have been added to validate adding multiple LWCAs in plain PKI environment and in IPA environment.
The
CASigningUnithas been updated to no longer log an exception if the cert or key is missing since in LWCA case the exception is used as a mechanism to trigger the key retriever so it is actually not a problem. Instead, the exception will only be logged by other code where the exception indicates a real problem.